Closed atarkowska closed 7 years ago
This can be rebased now.
@jburel I don't understand your comments. This PR is not ready for review, I will list it once is done.
I started to have a quick look (was coming from https://github.com/openmicroscopy/openmicroscopy/pull/4932, I wanted to understand things) Ignore if they are not useful
Just a heads up that this will need rebasing/merging from origin.
Test is finally passing, I am going to write more complex tests for other views. To test against multiple CIs I also need to allow extra args for omego in https://github.com/openmicroscopy/omero-test-daemon-c7-docker/pull/3
Still need to fix issue when config is not set
2016-12-07 18:58:03,688 ERROR [ django.request] (proc.17640) handle_uncaught_exception():256 Internal Server Error: /web/webclient/
Traceback (most recent call last):
File "/home/omero/workspace/OMERO-web/omero-virtualenv/lib/python2.7/site-packages/django/core/handlers/base.py", line 119, in get_response
resolver_match = resolver.resolve(request.path_info)
File "/home/omero/workspace/OMERO-web/omero-virtualenv/lib/python2.7/site-packages/django/core/urlresolvers.py", line 365, in resolve
for pattern in self.url_patterns:
File "/home/omero/workspace/OMERO-web/omero-virtualenv/lib/python2.7/site-packages/django/core/urlresolvers.py", line 401, in url_patterns
patterns = getattr(self.urlconf_module, "urlpatterns", self.urlconf_module)
File "/home/omero/workspace/OMERO-web/omero-virtualenv/lib/python2.7/site-packages/django/core/urlresolvers.py", line 395, in urlconf_module
self._urlconf_module = import_module(self.urlconf_name)
File "/usr/lib64/python2.7/importlib/__init__.py", line 37, in import_module
__import__(name)
File "/home/omero/workspace/OMERO-web/OMERO.web/lib/python/omeroweb/urls.py", line 84, in <module>
__import__(urlmodule)
File "/home/omero/workspace/OMERO-web/omero-virtualenv/lib/python2.7/site-packages/omero_mapr/urls.py", line 36, in <module>
DEFAULT_CONFIG = mapr_settings.CONFIG.iterkeys().next()
StopIteration
NOTE: I haven;t fixed that but there is a test catching that error. I will add better handler for empty config in the next version, thought
@aleksandra-tarkowska : is this worth a bump to 0.1.8 for IDR 0.3.1?
once I fix few bugs :)
:+1: my assumption is that we'll need/want a round of refactoring here soon, but very nice to have this in travis!
This PR initialize testing mapr using OmeroPy
clean up mapr_settings.py sysadmin needs to set up them manually:
see test_config.py, yeah that is a long one :-)