ome / omero-mapr

An OMERO.web app allowing to browse the data through attributes linked to the image
https://pypi.org/project/omero-mapr/
GNU Affero General Public License v3.0
5 stars 12 forks source link

well index fix metadata general #44

Closed will-moore closed 4 years ago

will-moore commented 5 years ago

See https://www.openmicroscopy.org/qa2/qa/feedback/27241/.

To test, with MAPR installed, search for a Well by ID and click on the Well in search results. The Well (index=0) should load in the right panel.

NB: This took me a while to track down as I'd forgotten that I had MAPR installed locally so when I tried editing my local right_plugin.general.js.html I saw no changes, and the local code already had the bug fixed. Need to remember that any changes made to this file in openmicroscopy have to be duplicated in mapr.

will-moore commented 5 years ago

NB: after running MAPR-merge job (see https://github.com/snoopycrimecop/omero-mapr/tree/master_merge_daily) you can install locally with:

pip install https://github.com/snoopycrimecop/omero-mapr/archive/master_merge_daily.zip
joshmoore commented 5 years ago

Need to remember that any changes made to this file

:+1: for short-term and eventually long-term fixes for this situation

mtbc commented 5 years ago

An initial attempt nets me a ValueError at /webclient/metadata_details/well/152/ invalid literal for int() with base 10: '' but I may not have installed correctly.

mtbc commented 5 years ago

It mentions this if it's a clue:

Request URL: http://localhost:4080/webclient/metadata_details/well/152/?index=&_=1547723492169
mtbc commented 5 years ago

It's consistent with that I'm using the merge build that pip freeze tells me omero-mapr==0.2.3?

will-moore commented 5 years ago

@mtbc - I'm not sure why that is still broken. Certainly the URL with index as an empty string is the problem index=&... but my fix gets rid of that behaviour for me. Hard to know whether I'm missing something or what...

mtbc commented 5 years ago

Very likely worth trying again with some competently installed merge mapr!

will-moore commented 5 years ago

Looks like same error reported again in https://www.openmicroscopy.org/qa2/qa/feedback/27723/

sbesson commented 4 years ago

Without this PR, I can reproduce the issue on production IDR

Screen Shot 2019-09-20 at 15 10 36

With this PR included and deployed to test71, the acquisition details for the selected well appear as expected. Screen Shot 2019-09-20 at 15 12 08

:+1: Merging, tagging and releasing.