ome / omero-mapr

An OMERO.web app allowing to browse the data through attributes linked to the image
https://pypi.org/project/omero-mapr/
GNU Affero General Public License v3.0
5 stars 13 forks source link

Add support for OMERO.web 5.27.0 #85

Closed sbesson closed 2 months ago

sbesson commented 2 months ago

Fixes #84

The internal logic of omeroweb.webclient.tree._marshal_image has changed to support the archived status of the images. This change adjusts the mapr logic consuming this internal API accordingly and declares OMERO.web 5.27.0 as the minimal version

sbesson commented 2 months ago

The integration failures are likely unrelated to this build and point to the fact that jinja2 is required by the integration tests through the usage of the deprecated omero.util.populate_metadata module but is not installed as a dependency of omero-mapr.

I am not sure of when this regression was introduced but I cannot see an obvious mechanism for declaring a dependency within the test phase of https://github.com/ome/omero-test-infra. Immediate options I can think of are:

Other suggestions/ideas from omero-test-infra maintainers welcome /cc @joshmoore @jburel @will-moore

sbesson commented 2 months ago

Closing as this workaround should be superseded by the work in https://github.com/ome/omero-web/pull/577 and a probably upcoming release of OMERO.web restoring compatiblity.

As discussed in https://github.com/ome/omero-web/pull/577#issuecomment-2314988850, this application is tightly coupled to the omeroweb.webclient module which deviates from the recommendation established in https://github.com/ome/omero-documentation/pull/1378. This means this app is particularly prone to any change made to the upstream Webclient. Its logic should probably be audited as this might inform which aspects of the webclient could be reasonably exposed as public API for downstreams apps to consume.

dominikl commented 2 weeks ago

I still get this error when I try to deploy a pilot with this PR included:

TASK [ome.iptables_raw : iptables-raw | enable iptables] **********************************************************************************************************
fatal: [19cd7a52-3664-4ed9-8c5f-f0b880e28221]: FAILED! => {"ansible_facts": {"discovered_interpreter_python": "/usr/bin/python3.9"}, "changed": false, "msg": "Unable to start service iptables: Job for iptables.service failed because the control process exited with error code.\nSee \"systemctl status iptables.service\" and \"journalctl -xeu iptables.service\" for details.\n"}