ome / omero-metadata

OMERO plugin for metadata manipulation https://www.openmicroscopy.org/omero/
GNU General Public License v2.0
7 stars 13 forks source link

Deletemap subcommand: proposed renaming and default behavior #12

Open sbesson opened 6 years ago

sbesson commented 6 years ago

See https://github.com/ome/omero-metadata/pull/11#issuecomment-420939255

There is some known variation between the various context classes invoked by metadata populate --context. Although the signatures of the constructor is maintained in sync, many of the options are really targetted at one context only.

DeleteMapAnnotationContext is probably the most obvious example. Unlike the other contexts, it uses the loops and ms options for the graph operation on the server. In addition, populate --context deletemap feels a bit contradictory from a semantic perspective.

A proposal would be to:

joshmoore commented 6 years ago

metadata delete is sufficiently broad that it might help to drive the renaming here. e.g.: bulkmap delete and mapannotation delete or metadata delete maps etc.