Fix flake8 issue raised following the Rocky Linux 9 image upgrade

ome / omero-metadata

OMERO plugin for metadata manipulation https://www.openmicroscopy.org/omero/

GNU General Public License v2.0

7 stars 13 forks source link

Fix flake8 issue raised following the Rocky Linux 9 image upgrade #84

Closed sbesson closed 8 months ago

sbesson commented 8 months ago

See https://github.com/ome/omero-metadata/actions/runs/7490016877/job/20387910739

I assume the new operating system is pulling a more recent of flake8 with additional warnings

jburel commented 8 months ago

@sbesson I was working on branch on that upgrade. I have one test failure on my account. You were faster :-)

jburel commented 8 months ago

Same failure test_deletebulkanns

sbesson commented 8 months ago

I won't have time to look into the other test failure today. Feel free to close this PR in favor of your branch

jburel commented 8 months ago

I am working on docker at the moment but will see if I can tonight

sbesson commented 8 months ago

After additional debugging, the issue comes from the following log statements

INFO     omero.util.Resources:__init__.py:657 Starting
INFO     omero.util.Resources:__init__.py:680 Halted

i.e. there is no functional regression but it's surprising that these statements would be send to the stdout

snoopycrimecop commented 8 months ago

Conflicting PR. Removed from build OMERO-plugins-push#369. See the console output for more details. Possible conflicts:

PR #55 kkoz 'Prevent users from creating columns with python keyword names'
- src/omero_metadata/populate.py
PR #64 will-moore 'Support images_by_name for Screen and Plate'
- src/omero_metadata/populate.py
PR #79 dominikl 'Remove leading whitespaces from csv'
- src/omero_metadata/populate.py

--conflicts

snoopycrimecop commented 8 months ago

Conflicting PR. Removed from build OMERO-plugins-push#370. See the console output for more details. Possible conflicts:

PR #55 kkoz 'Prevent users from creating columns with python keyword names'
- src/omero_metadata/populate.py
PR #64 will-moore 'Support images_by_name for Screen and Plate'
- src/omero_metadata/populate.py
PR #79 dominikl 'Remove leading whitespaces from csv'
- src/omero_metadata/populate.py

--conflicts

snoopycrimecop commented 8 months ago

Conflicting PR. Removed from build OMERO-plugins-push#371. See the console output for more details. Possible conflicts:

PR #55 kkoz 'Prevent users from creating columns with python keyword names'
- src/omero_metadata/populate.py
PR #64 will-moore 'Support images_by_name for Screen and Plate'
- src/omero_metadata/populate.py
PR #79 dominikl 'Remove leading whitespaces from csv'
- src/omero_metadata/populate.py

--conflicts

joshmoore commented 8 months ago

@dominikl @kkoz @will-moore: any opinions on what order these PRs should be merged? From my POV, this one could go in, but then everyone else will need to deal with the conflicts.

dominikl commented 8 months ago

I closed my PR.

will-moore commented 8 months ago

You can merge this first since there's only a couple of tiny conflicts with my PR, I can easily rebase and fix conflicts etc.

jburel commented 8 months ago

Thanks. So we can merge