search

ome / omero-ms-queue

GNU General Public License v3.0
3 stars 5 forks source link

Move to util #10

Closed c0c0n3 closed 7 years ago

c0c0n3 commented 7 years ago

This PR fully implements #9.

codecov-io commented 7 years ago

Codecov Report

Merging #10 into master will increase coverage by 0.17%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #10      +/-   ##
============================================
+ Coverage     82.18%   82.35%   +0.17%     
- Complexity     1385     1395      +10     
============================================
  Files           286      286              
  Lines          3929     3933       +4     
  Branches        184      184              
============================================
+ Hits           3229     3239      +10     
+ Misses          592      591       -1     
+ Partials        108      103       -5
Impacted Files Coverage Δ Complexity Δ
...n/java/ome/smuggler/core/msg/ReschedulingSink.java 100% <ø> (ø) 4 <0> (ø) :arrow_down:
...va/ome/smuggler/core/types/ImportConfigSource.java 100% <ø> (ø) 1 <0> (ø) :arrow_down:
...n/java/ome/smuggler/config/items/CryptoConfig.java 64.28% <ø> (ø) 7 <0> (ø) :arrow_down:
...nents/util/src/main/java/util/io/SourceReader.java 0% <ø> (ø) 0 <0> (?)
...va/ome/smuggler/providers/q/MessageBodyReader.java 100% <ø> (ø) 2 <0> (ø) :arrow_down:
...ler/config/wiring/crypto/SerializationFactory.java 100% <ø> (ø) 6 <0> (ø) :arrow_down:
...ain/java/ome/smuggler/core/types/OmeroDefault.java 80% <ø> (ø) 1 <0> (ø) :arrow_down:
...core/service/imports/impl/ImportMailFormatter.java 100% <ø> (ø) 12 <0> (ø) :arrow_down:
components/util/src/main/java/util/types/Nat.java 100% <ø> (ø) 6 <0> (?)
...re/service/omero/impl/SessionKeepAliveHandler.java 100% <ø> (ø) 7 <0> (ø) :arrow_down:
... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3db03c9...3d6f23d. Read the comment docs.

jburel commented 7 years ago

Also build locally


BUILD SUCCESSFUL

Total time: 15 mins 20.709 secs

Discussed with @c0c0n3 today, merging this PR so he can continue with the refactoring 2 more PR to come then we will tag to 0.3

joshmoore commented 7 years ago

Not sure what the content of the discussion is/was, but I'm concerned about the use of util.* as a package.

c0c0n3 commented 7 years ago

yip, and there's more...wait to see the new kew.* packages I'm going to merge in next week :-) But, honestly, I wouldn't stress about it. As soon as we decide on namespaces, I'll run a big-hammer refactoring task to rename the root packages. Basically a no-brainer, but I don't want to do it twice which is why I'm holding off until we know for sure what those namespaces are going be...

c0c0n3 commented 6 years ago

Closes #9