Serialisation

[c0c0n3]

This PR factors JSON and YAML serialisation out of the server component into util so to be able to reuse it in other components.

[codecov-io]

Codecov Report

Merging #16 into master will increase coverage by 0.11%. The diff coverage is 100%.

@@             Coverage Diff              @@
##             master      #16      +/-   ##
============================================
+ Coverage     86.02%   86.14%   +0.11%     
- Complexity     1656     1661       +5     
============================================
  Files           328      330       +2     
  Lines          4365     4373       +8     
  Branches        185      183       -2     
============================================
+ Hits           3755     3767      +12     
+ Misses          528      525       -3     
+ Partials         82       81       -1

Impacted Files	Coverage Δ	Complexity Δ
...gler/config/wiring/imports/ImportServiceBeans.java	100% <ø> (ø)	10 <0> (ø)	:arrow_down:
...e/smuggler/config/providers/YmlResourceReader.java	100% <ø> (ø)	2 <0> (ø)	:arrow_down:
...src/main/java/ome/smuggler/run/UndertowYmlGen.java	100% <ø> (ø)	2 <0> (ø)	:arrow_down:
...java/util/serialization/json/JsonStreamReader.java	100% <ø> (ø)	2 <0> (?)
...e/smuggler/config/wiring/imports/ImportQBeans.java	100% <ø> (ø)	4 <0> (ø)	:arrow_down:
...r/src/main/java/ome/smuggler/run/ImportYmlGen.java	100% <ø> (ø)	2 <0> (ø)	:arrow_down:
...smuggler/config/wiring/imports/ImportGcQBeans.java	100% <ø> (ø)	4 <0> (ø)	:arrow_down:
...java/util/serialization/json/JsonSourceReader.java	100% <ø> (ø)	4 <0> (?)
...java/util/serialization/json/JsonStreamWriter.java	100% <ø> (ø)	2 <0> (?)
...r/src/main/java/ome/smuggler/run/CryptoYmlGen.java	100% <ø> (ø)	2 <0> (ø)	:arrow_down:
... and 18 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 106a0d5...a12c5cd. Read the comment docs.

[c0c0n3]

yes, i removed that import from cryptoserializationbeans, not sure why your diff showed you it was there. mysteries of github...

On Sat, 29 Sep 2018 at 06:57, jean-marie burel notifications@github.com wrote:

@jburel commented on this pull request.

In components/server/src/main/java/ome/smuggler/config/wiring/crypto/CryptoSerializationBeans.java https://github.com/openmicroscopy/omero-ms-queue/pull/16#discussion_r221416213 :

import org.springframework.context.annotation.Bean; import org.springframework.context.annotation.Configuration;

+import ome.smuggler.core.types.CryptoConfigSource;

should this be factored out too?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/openmicroscopy/omero-ms-queue/pull/16#pullrequestreview-160066866, or mute the thread https://github.com/notifications/unsubscribe-auth/AMnsHcNf9-gVtgrPZwRNJGexDfMPgw8rks5ufv2bgaJpZM4R4nqG .