Move omero_to_zarr.py to omero-cli-zarr

ome / omero-ms-zarr

Experimental micro-service for implementing the Zarr spec over HTTP

https://www.openmicroscopy.org/omero

GNU General Public License v2.0

17 stars 12 forks source link

Move omero_to_zarr.py to omero-cli-zarr #51

Closed joshmoore closed 4 years ago

joshmoore commented 4 years ago

Looking at https://github.com/ome/omero-cli-zarr/blob/146706c86fb12b5052d806d98e7ac77277ca4b37/notebooks/idr0041-3430725-zarr-roi.ipynb this script should really be in that repository.

joshmoore commented 4 years ago

Here are the primary differences between this script and the one already existing in omero-cli-zarr:

omero-cli-zarr:
- caches numpy
- supports a target directory
- adds group metadata
this script uses zarr.group(store=store, overwrite=True) -- not sure if there is a functional difference.

will-moore commented 4 years ago

Thanks for the cleanup. I also don't know about zarr.group(store=store, overwrite=True) but omero-cli-zarr root = zarr.open_group(name, mode='w') seems to be doing what we want. 👍