ome / omero-parade

OMERO.web plugin for displaying Dataset thumbnails or Plates in webclient center panel
GNU Affero General Public License v3.0
1 stars 12 forks source link

Use vite.js instead of webpack #122

Closed will-moore closed 1 year ago

will-moore commented 1 year ago

Replace webpack with vite.js.

This also updates all dependencies to latest versions.

To test:

will-moore commented 1 year ago

Failing build with:

Error: Package: 2:nodejs-18.16.0-1nodesource.x86_64 (nodesource)
           Requires: libstdc++.so.6(GLIBCXX_3.4.20)(64bit)
Error: Package: 2:nodejs-18.16.0-1nodesource.x86_64 (nodesource)
           Requires: libstdc++.so.6(GLIBCXX_3.4.21)(64bit)
Error: Package: 2:nodejs-18.16.0-1nodesource.x86_64 (nodesource)
           Requires: libm.so.6(GLIBC_2.27)(64bit)
Error: Package: 2:nodejs-18.16.0-1nodesource.x86_64 (nodesource)
           Requires: libstdc++.so.6(CXXABI_1.3.9)(64bit)
Error: Package: 2:nodejs-18.16.0-1nodesource.x86_64 (nodesource)
           Requires: libc.so.6(GLIBC_2.28)(64bit)
will-moore commented 1 year ago

This is causing failure in merge-ci web deploy: see https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-web/1634/console because it needs a different version of node.js (same as failures above).

EDIT - removed 15th June

will-moore commented 1 year ago

Just for the record, this PR (migration from webpack to vite.js) was helped in a big way by chatGPT as follows:

Screenshot 2023-04-19 at 13 33 35

Screenshot 2023-04-19 at 13 33 47

Screenshot 2023-04-19 at 13 33 57

Screenshot 2023-04-19 at 13 34 07

Screenshot 2023-04-19 at 13 34 24

jburel commented 1 year ago

This has been evaluated on new merge-ci

Screenshot 2023-06-16 at 14 38 43
will-moore commented 1 year ago

Updated node version and README

jburel commented 1 year ago

We should still have omero.web as a requirement cf. omero.figure

will-moore commented 1 year ago

The text says OMERO.web is required. I was going to put a version of omero-web, and then I realised that this is already specified in setup.py (as are all dependencies) and I didn't want to duplicate it. I'm not sure saying "This requires omero-web" adds much and "This requires omero-web>=5.6.1" is duplication, so I think it's cleaner without?

jburel commented 1 year ago

I was thinking something like

OMERO.figure
============

An OMERO.web app for creating figures from images in OMERO.

For full details see `SUPPORT.md <https://github.com/ome/omero-figure/blob/master/SUPPORT.md>`_.

Requirements
------------

* OMERO.web 5.6.0 or newer.

I think it is easier to quickly identify what is what

will-moore commented 1 year ago

Updated README as suggested

joshmoore commented 1 year ago

Latest builds since June 21st are failing.

e.g. https://latest-ci.openmicroscopy.org/jenkins/job/OMERO-web/1365/console

00:15:06     > omero_parade@0.1.3 build /tmp/pip-req-build-_2trlcwo
00:15:06     > vite build
00:15:06     
00:15:06     (node:46956) ExperimentalWarning: The ESM module loader is experimental.
00:15:06     file:///tmp/pip-req-build-_2trlcwo/node_modules/vite/bin/vite.js:7
00:15:06         await import('source-map-support').then((r) => r.default.install())
00:15:06         ^^^^^
00:15:06     
00:15:06     SyntaxError: Unexpected reserved word
00:15:06         at Loader.moduleStrategy (internal/modules/esm/translators.js:81:18)
00:15:06         at async link (internal/modules/esm/module_job.js:37:21)
00:15:06     npm ERR! code ELIFECYCLE
00:15:06     npm ERR! errno 1
00:15:06     npm ERR! omero_parade@0.1.3 build: `vite build`
00:15:06     npm ERR! Exit status 1
00:15:06     npm ERR!
00:15:06     npm ERR! Failed at the omero_parade@0.1.3 build script.
00:15:06     npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

Is this related? Does something need updating in the build?

will-moore commented 1 year ago

Ah, yes - I think latest-ci infrastructure hasn't been updated as merge-ci has.

jburel commented 1 year ago

@will-moore could you remove parade from latest-ci for now?

imagesc-bot commented 7 months ago

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/replacing-omero-insight-with-omero-web-scripts/86942/18