search

ome / omero-parade

OMERO.web plugin for displaying Dataset thumbnails or Plates in webclient center panel
GNU Affero General Public License v3.0
1 stars 12 forks source link

ImageIcon maxHeight #31

Closed will-moore closed 6 years ago

will-moore commented 6 years ago

Fixes the rendering of max-height for Dataset thumbnails, needed when images are taller than they are wide. Previously the height={iconSizes.height + "px"} was failing because iconSizes had max-height but not height.

Before:

screen shot 2018-05-10 at 15 20 15

After:

screen shot 2018-05-10 at 15 21 41

To test, view Dataset thumbnails of tall images.

pwalczysko commented 6 years ago

It works as described in the header. I do not doubt this is an improvement.

Still, see the thumbs in parade and webclient below. I think it is fine, but just in case we cannot do any better (the parade forces the image into the square thumb, although it is very high and not very wide). http://web-dev-merge.openmicroscopy.org/webclient/?show=image-97104 user-4

Parade screen shot 2018-05-11 at 10 11 49

Webclient screen shot 2018-05-11 at 10 12 07