search

ome / omero-parade

OMERO.web plugin for displaying Dataset thumbnails or Plates in webclient center panel
GNU Affero General Public License v3.0
1 stars 12 forks source link

Load all thumbnails asynchronously #32

Closed chris-allan closed 6 years ago

chris-allan commented 6 years ago

Switches all thumbnail loading to use asynchronous bulk strategies and implements remote call cancellation.

The thumbnail loading behaviour should now be identical in user experience to the existing thumbnail plugin.

OMERO 5.4.6 with openmicroscopy/openmicroscopy#5746 is essential to ensure that no background event craziness is impacting Parade and its thumbnail loading.

/cc @emilroz

snoopycrimecop commented 6 years ago

Conflicting PR. Removed from build parade-merge#59. See the console output for more details. Possible conflicts:

--conflicts Conflict resolved in build parade-merge#60. See the console output for more details.

will-moore commented 6 years ago

Testing locally it seems to be working nicely. If you are happy with #31 and want to merge it and fix the conflict, then we can test on web-dev-merge. (or could exclude #31 if not).

will-moore commented 6 years ago

Thumbnails loading fine for single page app. I noticed that in the Table layout that thumbnails are still loading individually, so they are re-loaded when you switch to that layout. And when you switch back to thumbnails layout they are batch-loaded again.

I haven't looked at the code in detail yet, but I guess you may want the thumbnail data to be in a higher component to that it's available to all 3 layouts?

will-moore commented 6 years ago

This is working very nicely now. No re-loading of thumbnails when switching layouts and asyn loading is much faster.

jburel commented 6 years ago

Everything looks good after rebuilding We will need to indicate that parade 0.1.0 works best with version of OMERO 5.4.6 or newer

chris-allan commented 6 years ago

Agreed.

I'll try to remember to add it to the README.