Plot clean up - Githubissues

ome / omero-parade

OMERO.web plugin for displaying Dataset thumbnails or Plates in webclient center panel

GNU Affero General Public License v3.0

1 stars 12 forks source link

Plot clean up #41

Closed emilroz closed 6 years ago

emilroz commented 6 years ago

List of changes:

plot is now re-sizable in width with the min-width set to 650px
scales, ticks, and grid lines are added; grid lines are fixed for now to 2 along Y and 3 along X
img -> point:
tooltip with table values:
multiselection with points:
table row highlighting

jburel commented 6 years ago

First impression: very nice

jburel commented 6 years ago

@will-moore I think it will l be good to include this PR in 0.1.0 and show in the last part of the workshop when we switch to the Plot layout

jburel commented 6 years ago

Tooltip is displayed when mousing over a point
Selecting multiples points work nicely. The elements are correctly selected in the tree, in the table and the thumbnails view. The rows are correctly highlighted in the table

When clicking on an area without points, I was expecting to have the selection reset. This is currently not the case. This could be an improvement in a follow up PR

will-moore commented 6 years ago

I agree - it would be nice to have this in the first release. But I'm not sure about the "clicking on area without points -> reset selection". If you drag-select on a region without points then that will work. But otherwise it's only the points that are clickable - seems OK to me.

jburel commented 6 years ago

Selecting a region without points will do the trick. Unless @emilroz & @chris-allan are planning more work on this PR, I will include it in 0.1.0

chris-allan commented 6 years ago

Not planning to do any more work on it. It's rather ropy as it is already and really needs a proper charting library.

jburel commented 6 years ago

Ok so we go with that for 0.1.0 since it is much nicer than the previous implementation It will be less "disrupting" to the users with this PR in when we switch to a dedicated charting library