Closed emilroz closed 6 years ago
First impression: very nice
@will-moore I think it will l be good to include this PR in 0.1.0 and show in the last part of the workshop when we switch to the Plot layout
When clicking on an area without points, I was expecting to have the selection reset. This is currently not the case. This could be an improvement in a follow up PR
I agree - it would be nice to have this in the first release. But I'm not sure about the "clicking on area without points -> reset selection". If you drag-select on a region without points then that will work. But otherwise it's only the points that are clickable - seems OK to me.
Selecting a region without points will do the trick. Unless @emilroz & @chris-allan are planning more work on this PR, I will include it in 0.1.0
Not planning to do any more work on it. It's rather ropy as it is already and really needs a proper charting library.
Ok so we go with that for 0.1.0 since it is much nicer than the previous implementation It will be less "disrupting" to the users with this PR in when we switch to a dedicated charting library
List of changes:
plot is now re-sizable in width with the min-width set to 650px
scales, ticks, and grid lines are added; grid lines are fixed for now to 2 along Y and 3 along X
img -> point:![picture2](https://user-images.githubusercontent.com/2600663/40173859-80d4da0e-59d3-11e8-87af-d5960da9e366.PNG)
tooltip with table values:![picture1](https://user-images.githubusercontent.com/2600663/40173871-8cd0b0da-59d3-11e8-8578-7ad793f36089.png)
multiselection with points:![picture3](https://user-images.githubusercontent.com/2600663/40173892-9be3f4b0-59d3-11e8-997a-f75ac090f8b1.PNG)
table row highlighting![picture4](https://user-images.githubusercontent.com/2600663/40173911-a8a9af00-59d3-11e8-88d6-3d456640ae11.PNG)