Closed jburel closed 5 years ago
:+1: for fixing the build. There are a few major versions bumps but I am not able to assess whether this would affect functionalities. (EDIT: see https://github.com/ome/omero-parade/pull/39#issuecomment-439320869)
Conflicting PR. Removed from build parade-merge#194. See the console output for more details. Possible conflicts:
--conflicts Conflict resolved in build parade-merge#195. See the console output for more details.
On eel, as user-3, project idr0021
In parade, select Table, then Image Count, Total Area, then Bounding Box -> crash
this is repeatable
Traceback (most recent call last):
File "/home/hudson/virtualenv/lib/python2.7/site-packages/django/core/handlers/base.py", line 132, in get_response
response = wrapped_callback(request, *callback_args, **callback_kwargs)
File "/opt/hudson/workspace/WEB-DEV-merge-deploy/OMERO.py/lib/python/omeroweb/decorators.py", line 486, in wrapped
retval = f(request, *args, **kwargs)
File "/home/hudson/virtualenv/lib/python2.7/site-packages/omero_parade/views.py", line 170, in get_data
data = module.get_data(request, data_name, conn)
File "/home/hudson/virtualenv/lib/python2.7/site-packages/omero_parade/table_filters/data_providers.py", line 121, in get_data
named_column_index = column_names.index(column_name)
ValueError: 'Total Area' is not in list
<WSGIRequest
path:/parade/data/VGFibGVfVG90YWwgQXJlYQ==/,
GET:<QueryDict: {u'project': [u'4501'], u'_': [u'1542626103876']}>,
POST:<QueryDict: {}>,
COOKIES:{'__utma': '266053329.2142887685.1495792616.1500022766.1500022766.1',
'_ga': 'GA1.2.2142887685.1495792616',
'_gid': 'GA1.2.1764551888.1542626076',
'csrftoken': '4YSve37bIcV2uyRnV5WM7qYZoYelyNG7',
'phpbb3_a9mfv_k': '47f4d5f8e84d31f0',
'phpbb3_a9mfv_sid': '3df023a607df40b1c6af2270456f7421',
'phpbb3_a9mfv_u': '2759',
'sessionid': '
'style_cookie': 'null'},
META:{u'CSRF_COOKIE': u'4YSve37bIcV2uyRnV5WM7qYZoYelyNG7',
'HTTP_ACCEPT': 'application/json, text/javascript, */*; q=0.01',
'HTTP_ACCEPT_ENCODING': 'gzip, deflate',
'HTTP_ACCEPT_LANGUAGE': 'en-GB,en;q=0.5',
'HTTP_CONNECTION': 'close',
'HTTP_COOKIE': 'csrftoken=4YSve37bIcV2uyRnV5WM7qYZoYelyNG7; _ga=GA1.2.2142887685.1495792616; style_cookie=null; phpbb3_a9mfv_u=2759; phpbb3_a9mfv_k=47f4d5f8e84d31f0; phpbb3_a9mfv_sid=3df023a607df40b1c6af2270456f7421; __utma=266053329.2142887685.1495792616.1500022766.1500022766.1; _gid=GA1.2.1764551888.1542626076; sessionid=wj0kmqehr9dfcecryln6kbn6odqxwuj4',
'HTTP_HOST': 'web-dev-merge.openmicroscopy.org',
'HTTP_REFERER': 'http://web-dev-merge.openmicroscopy.org/webclient/',
'HTTP_USER_AGENT': 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:63.0) Gecko/20100101 Firefox/63.0',
'HTTP_X_FORWARDED_FOR': '134.36.162.66',
'HTTP_X_FORWARDED_PROTO': 'http',
'HTTP_X_REQUESTED_WITH': 'XMLHttpRequest',
'PATH_INFO': u'/parade/data/VGFibGVfVG90YWwgQXJlYQ==/',
'QUERY_STRING': 'project=4501&_=1542626103876',
'RAW_URI': '/parade/data/VGFibGVfVG90YWwgQXJlYQ%3D%3D/?project=4501&_=1542626103876',
'REMOTE_ADDR': '127.0.0.1',
'REMOTE_PORT': '50948',
'REQUEST_METHOD': 'GET',
'SCRIPT_NAME': u'',
'SERVER_NAME': '127.0.0.1',
'SERVER_PORT': '4080',
'SERVER_PROTOCOL': 'HTTP/1.0',
'SERVER_SOFTWARE': 'gunicorn/19.9.0',
'gunicorn.socket': <socket._socketobject object at 0x5edcf30>,
'wsgi.errors': <gunicorn.http.wsgi.WSGIErrorsWrapper object at 0x5d38d90>,
'wsgi.file_wrapper': <class 'gunicorn.http.wsgi.FileWrapper'>,
'wsgi.input': <gunicorn.http.body.Body object at 0x6199790>,
'wsgi.multiprocess': True,
'wsgi.multithread': False,
'wsgi.run_once': False,
'wsgi.url_scheme': 'http',
'wsgi.version': (1, 0)}>
If you circumvent the bug https://github.com/ome/omero-parade/pull/53#issuecomment-439860940 by selecting the items in the dropdown in the order of appearance from top to bottom, then the graph does not work anyway.
I cannot reproduce the bug described by the first comment
Cannot repeat the bug https://github.com/ome/omero-parade/pull/53#issuecomment-439860940 either. But the behaviour of the graph is not okay - I also seem to have some weird behavour on filtering by bounding box
@jburel - If this is good to merge (I think so) then please merge to avoid conflict with #55 (which needs the same fix to pass travis). Thanks
@will-moore: @pwalczysko reported a problem with the bounding box. I did not have time to check and I could not reproduce the issue. Will you have time to test?
I don't see any bugs apart from the slightly strange behaviour caused by one image having a much larger Bounding box than all the other images. This makes a funny-looking plot and the filtering behaviour is wacky because the range of the slider is big compared to the lower values.
ok thanks @will-moore. Merging so we can fix the build and move forward
Update web-cli
This should fix the failure noticed in build https://travis-ci.org/jburel/omero-plugins/builds/455462210