search

ome / omero-parade

OMERO.web plugin for displaying Dataset thumbnails or Plates in webclient center panel
GNU Affero General Public License v3.0
1 stars 12 forks source link

table.close() in try/finally blocks #58

Closed will-moore closed 5 years ago

will-moore commented 5 years ago

Make sure we call table.close() whenever we open a table.

cc @joshmoore @chris-allan

joshmoore commented 5 years ago 
./omero_parade/table_filters/data_providers.py:55:5: E722 do not use bare except'
./omero_parade/table_filters/data_providers.py:151:80: E501 line too long (82 > 79 characters)

Once this is fixed, I could see releasing a 0.1.3

will-moore commented 5 years ago

@joshmoore flake8 fixed (and I used finally instead of except, which I should have done first time).

will-moore commented 5 years ago

If we're releasing, it would be great to have https://github.com/ome/omero-parade/pull/55 merged and included since we've got several reports of that bug (internally and externally).

joshmoore commented 5 years ago

Merging for 0.1.3