ome / omero-parade

OMERO.web plugin for displaying Dataset thumbnails or Plates in webclient center panel
GNU Affero General Public License v3.0
1 stars 12 forks source link

Fix loading of Key-Value pairs #69

Closed will-moore closed 4 years ago

will-moore commented 4 years ago

Fixes loading of Key-Value pairs on Python3. Error was

AttributeError: 'dict_keys' object has no attribute 'sort'

To test just this fix on py3-ci, you can go to https://py3-ci.openmicroscopy.org/web/parade/filters/script/Key_Value/?project=2357 (user-3). which is currently failing.

To test the full app locally, you need to install merged branch from snoopy (py3-ci not building JavaScript).

pwalczysko commented 4 years ago

The url is working as expected and delivers the KVPs. Consulting with @will-moore we conclude that parade itself s not possible to test, but this is anotehr problem.

Ready to merge fmpov

joshmoore commented 4 years ago

Immediate release as 0.2.dev2?

will-moore commented 4 years ago

That would be great. Then we could have py3-ci pip install that tag and see if that fixes the current deployment.

joshmoore commented 4 years ago

https://libraries.io/pypi/omero-parade/0.2.dev2