Closed will-moore closed 4 years ago
Works as expected. Ready to merge FMPOV
Leaving open for discussion with @emilroz.
Assuming all are :thumbsup:, @will-moore, any reason to not roll out as 0.2.1?
If #75 doesn't take too long, it would be nice to get that in too...
Sorry for being late to the party. @will-moore I think there might have been an issue with the point selection on the plot. I'll try to do some tests locally to see if I can reproduce.
@will-moore removing the z-index (local test) causes the grid lines to appear above the points and makes the points unselectable:
@emilroz Thanks for that - seems to be fixed with z-index:1
(and is still under the Tag dialog).
@emilroz thanks a lot for catching this https://github.com/ome/omero-parade/pull/74#issuecomment-584407166
Somehow, OMERO.parade is crashing when any table data are attempted to be added, user-3, project https://merge-ci.openmicroscopy.org/web/webclient/?show=project-3060
@pwalczysko Thanks, that was due to the csv PR and is fixed there: https://github.com/ome/omero-parade/pull/75/commits/e4dd8812ae3183e2b3365f45517a249694293436
This fixes the bug where the Tag dialog appears behind the parade scatter plot.
To test:
I don't know what issue the z-index css was trying to fix, or if it's still needed at-all? Any ideas @emilroz ?