z-index tag dialog fix - Githubissues

ome / omero-parade

OMERO.web plugin for displaying Dataset thumbnails or Plates in webclient center panel

GNU Affero General Public License v3.0

1 stars 12 forks source link

z-index tag dialog fix #74

Closed will-moore closed 4 years ago

will-moore commented 4 years ago

This fixes the bug where the Tag dialog appears behind the parade scatter plot.

To test:

View scatter plot in parade
Select Image(s) and open Tag dialog - should work normally.
Check for other css issues?

I don't know what issue the z-index css was trying to fix, or if it's still needed at-all? Any ideas @emilroz ?

pwalczysko commented 4 years ago

Works as expected. Ready to merge FMPOV

joshmoore commented 4 years ago

Leaving open for discussion with @emilroz.

Assuming all are :thumbsup:, @will-moore, any reason to not roll out as 0.2.1?

will-moore commented 4 years ago

If #75 doesn't take too long, it would be nice to get that in too...

emilroz commented 4 years ago

Sorry for being late to the party. @will-moore I think there might have been an issue with the point selection on the plot. I'll try to do some tests locally to see if I can reproduce.

emilroz commented 4 years ago

@will-moore removing the z-index (local test) causes the grid lines to appear above the points and makes the points unselectable:

will-moore commented 4 years ago

@emilroz Thanks for that - seems to be fixed with z-index:1 (and is still under the Tag dialog).

pwalczysko commented 4 years ago

@emilroz thanks a lot for catching this https://github.com/ome/omero-parade/pull/74#issuecomment-584407166

pwalczysko commented 4 years ago

Somehow, OMERO.parade is crashing when any table data are attempted to be added, user-3, project https://merge-ci.openmicroscopy.org/web/webclient/?show=project-3060

will-moore commented 4 years ago

@pwalczysko Thanks, that was due to the csv PR and is fixed there: https://github.com/ome/omero-parade/pull/75/commits/e4dd8812ae3183e2b3365f45517a249694293436