Support filtering by OMERO.tables on Dataset

ome / omero-parade

OMERO.web plugin for displaying Dataset thumbnails or Plates in webclient center panel

GNU Affero General Public License v3.0

1 stars 12 forks source link

Support filtering by OMERO.tables on Dataset #86

Open will-moore opened 3 years ago

will-moore commented 3 years ago

See https://forum.image.sc/t/using-omero-parade-on-dataset-level-and-image-level-omero-tables/50180

This fixes a limitation of not supporting OMERO.table filtering on Datasets.

To test:

See https://merge-ci.openmicroscopy.org/web/webclient/?show=dataset-3183 (user-3)
I created this by linking an OMERO.table (File Annotation on a Project) to one of the Datasets in the Project:

$ omero obj new DatasetAnnotationLink parent=Dataset:151 child=FileAnnotation:3774

I also made the Dataset an Orphan, by removing it from the Project.
Then you can choose the Dataset alone in OMERO.parade and filter -> Table

Screenshot 2021-03-16 at 11 50 19

imagesc-bot commented 3 years ago

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/using-omero-parade-on-dataset-level-and-image-level-omero-tables/50180/2

pwalczysko commented 3 years ago

I guess there would be a case for not showing the Show Datasets checkbox if youi are working only on one dataset ?

Screenshot 2021-03-18 at 16 23 27

pwalczysko commented 3 years ago

One RFE, https://github.com/ome/omero-parade/pull/86#issuecomment-802065956 which might be for another PR. I went over just checking the filtering and added values from the table to columns. Except https://github.com/ome/omero-parade/pull/86#issuecomment-802065956 I noticed also that the graph autoformat of axes does not seem right

Screenshot 2021-03-18 at 16 27 54

pwalczysko commented 3 years ago

The filtering works fine, happy for the RFEs https://github.com/ome/omero-parade/pull/86#issuecomment-802077325 to be fixed in a follow-up PR.

will-moore commented 3 years ago

The plot axis issue (https://github.com/ome/omero-parade/pull/86#issuecomment-802077325) is probably due to the fact that I used the OMERO.table for the whole Project, and just linked it to one Dataset for this test. So it has Image IDs in the table that are causing the min/max range of Image IDs to extend beyond those that are in this Dataset. So, I think we can ignore this unless we know of workflows where this would routinely be a problem.

imagesc-bot commented 3 years ago

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/using-omero-parade-on-dataset-level-and-image-level-omero-tables/50180/6

will-moore commented 2 years ago

As seen from https://github.com/ome/omero-parade/issues/90, users are trying to filter images on a Dataset which has attached csv/tables. In this case, the Dataset is an orphan.

will-moore commented 1 year ago

Avoid conflict with https://github.com/ome/omero-parade/pull/122

--exclude