search

ome / omero-prometheus-tools

Utilities for monitoring OMERO with Prometheus
2 stars 9 forks source link

Convert OMERO strings to unicode #4

Closed manics closed 6 years ago

manics commented 6 years ago

Fixes https://trello.com/c/lLxHorjS/5609-prom-exporter-unicodedecodeerror

OMERO rstrings may contain unicode, but they are not automatically converted to Python unicode. This solution involved some trial-and-error.

Testing: omero-prometheus-tools.py -s pub-omero.openmicroscopy.org -u PRIVILEGED-USER -w PASSWORD -v -c etc/prometheus-omero-counts.yml against a server that has Unicode group names e.g. pub-omero and go to http://localhost:9449/

manics commented 6 years ago

Added a test (uses modified omero-test-infra)

Though looks like travis isn't enabled on this repo.

manics commented 6 years ago

Thanks, I've got it working with test-data and lib-test based on https://github.com/ome/minimal-omero-client/pull/27 There's a bug though: https://github.com/openmicroscopy/omero-test-infra/pull/24

joshmoore commented 6 years ago

Closing and re-opening to trigger travis.

joshmoore commented 6 years ago 
+docker run --link omeroprometheustools_omero_1:omero --net omeroprometheustools_default --rm -d -p 9449:9449 --name omero-prometheus-tools test -s omero -u root -w omero -c /opt/omero-prometheus-tools/etc/prometheus-omero-counts.yml -v
03f86f091f8ce3938bdc610b1ad31e629ce7a196c13f0f6ff9b0d6d24fec9a39
+sleep 10
+./test.py
PASSED

and weekly cron activated.

joshmoore commented 6 years ago

Nicely done. Shall his become 0.1.1?

manics commented 6 years ago

👍 for 0.1.1.