search

ome / omero-py

Python project containing Ice remoting code for OMERO
https://www.openmicroscopy.org/omero
GNU General Public License v2.0
22 stars 32 forks source link

Remove omero_ext.argparse #115

Closed manics closed 2 years ago

manics commented 4 years ago

See https://github.com/ome/omero-py/pull/110

This will conflict rebased

--exclude see https://github.com/ome/omero-py/pull/115#pullrequestreview-322991815

joshmoore commented 4 years ago 
E           Exception: Missing prompt: 'Server: [localhost:4064]'

etc.

manics commented 4 years ago

I'm still no nearer to finding out what's happening.

sbesson commented 4 years ago

The last two commits fix the upstream conflicts following the inclusion of #123 and the failing unit tests (33f0017). It looks like the upstream argparse enforces positional arguments to be appended to the command.

This should be ready for re-inclusion in the daily builds and a round of CLI review.

In terms of API, is there a way to have omero_ext.argparse simply alias the upstream argparse library and deprecate it?

joshmoore commented 4 years ago

It looks like the upstream argparse enforces positional arguments

This will have a pretty wide impact. e.g. bin/omero -s localhost login is pretty common.