ome / omero-py

Python project containing Ice remoting code for OMERO
https://www.openmicroscopy.org/omero
GNU General Public License v2.0
22 stars 32 forks source link

changelog: list breaking changes #125

Closed joshmoore closed 4 years ago

joshmoore commented 4 years ago

cc: @ome/python

will-moore commented 4 years ago

image.exportOmeTiff()

will-moore commented 4 years ago

Previously where you did:

image = conn.getObject("Image", id)
Image.open(StringIO(image.renderJpeg))

now you need to do:

Image.open(BytesIO(image.renderJpeg))

That's not so much a BlitzGateway change, since it's just returning re.renderCompressed()

Same for:

joshmoore commented 4 years ago

Agreed. I think we add BytesIO, str.decode() etc to a more general migration guide as opposed to our own CHANGELOG.

will-moore commented 4 years ago

conn.createOriginalFileFromFileObj() needs to take BytesIO file object instead of StringIO.

will-moore commented 4 years ago

Do we want to mention omero_type(longValue) and omero.rtypes.wrap(longValue) won't return rlong?

joshmoore commented 4 years ago

Merging after a quick sign-off for posting on image.sc. Happy to have follow-ups. thanks, @will-moore.