Disable new testLoadGlob when OMERODIR not set

ome / omero-py

Python project containing Ice remoting code for OMERO

https://www.openmicroscopy.org/omero

GNU General Public License v2.0

22 stars 32 forks source link

Disable new testLoadGlob when OMERODIR not set #140

Closed manics closed 4 years ago

manics commented 4 years ago

https://github.com/ome/omero-py/pull/14 and https://github.com/ome/omero-py/pull/137 overlapped so were not tested together.

joshmoore commented 4 years ago

Merging proactively so we can get other PRs green, but I think a test method (additional or otherwise) that either doesn't require OMERODIR to be set (using version, etc) or creates its own OMERODIR would be appropriate.

manics commented 4 years ago

I tried that, it was reverted in https://github.com/ome/omero-py/pull/137/commits/d1f4dc2bf259ccf3540e38a17f0cf9a7a79fda33 because OMERODIR needs to be set before importing the CLI.

joshmoore commented 4 years ago

Not sure if that should be considered a bug, but you can also reset the value:

self.ctx.dir = NEW_OMERODIR