ome / omero-py

Python project containing Ice remoting code for OMERO
https://www.openmicroscopy.org/omero
GNU General Public License v2.0
22 stars 32 forks source link

Update README release commands to sign release tags #221

Closed sbesson closed 4 years ago

sbesson commented 4 years ago

Minor improvements from my experience releasing omero-py 5.7.0.

A second minor is that if the previous dev version does not match the expected release version (in my case 5.6.3.dev0 was released as 5.7.0), the default command will obviously create an undesired tag/commit. Options are either:

joshmoore commented 4 years ago

Doh! Somewhere along the line we lost this:

(base) /opt $grep sign */.bumpversion.cfg
ome-zarr-py/.bumpversion.cfg:sign_tags = True
omero-dropbox/.bumpversion.cfg:sign_tags = True
omero-figure/.bumpversion.cfg:sign_tags = True
omero-signup/.bumpversion.cfg:sign_tags = True
sbesson commented 4 years ago

Updated to set the defaults in the configuration file instead.

joshmoore commented 4 years ago

Thanks. I've blindly been assuming I've had this active everywhere.