ome / omero-py

Python project containing Ice remoting code for OMERO
https://www.openmicroscopy.org/omero
GNU General Public License v2.0
20 stars 33 forks source link

Always marshal tile metadata on presence of pyramid #239

Closed chris-allan closed 4 years ago

chris-allan commented 4 years ago

It is possible, in particular for floating point data, that a pyramid is present even if the server thinks a pyramid is not required. The condition for tile metadata being available is now pyramid presence.

See:

chris-allan commented 4 years ago

Additional requirement for restoring all the pyramid metadata that was started in ome/omero-web#193.

/cc @sbesson

joshmoore commented 4 years ago

The change seems straight-forward enough, though I imagine we should clarify in https://github.com/ome/omero-blitz/blob/master/src/main/slice/omero/api/PyramidService.ice when each of the methods should be used.

chris-allan commented 4 years ago

@joshmoore: Yeah, in particular requirePixelsPyramid() as currently documented is already largely incorrect: