Adds optional extra args to the util

ome / omero-py

Python project containing Ice remoting code for OMERO

https://www.openmicroscopy.org/omero

GNU General Public License v2.0

20 stars 33 forks source link

Closed glyg closed 4 years ago

glyg commented 4 years ago

Follow up on #235

The extra test is very minimal for now, I wanted to get your input before doing more.

I choose to put it in test_import.py to avoid rewriting all the mock & setup machinery, but I'm not sure it's ok / good practice...

glyg commented 4 years ago

I'll add test to check that the extra args are included correctly

glyg commented 4 years ago

sorry for the messy diff, I passed black on the file automatically, I can revert that if you want. I don't know if further tests / doc are needed?

joshmoore commented 4 years ago

Yeah, let's force push away the application of black here. We'll do that in concert with a GitHub Action to make sure it stays formatted.

Otherwise, test looks good. Thanks.

cc: @sbesson

sbesson commented 4 years ago

Thanks @glyg, merging for inclusion in the upcoming minor release of omero-py

glyg commented 4 years ago

Great! Thanks to both of you!