search

ome / omero-py

Python project containing Ice remoting code for OMERO
https://www.openmicroscopy.org/omero
GNU General Public License v2.0
20 stars 33 forks source link

Add support for mutliple Ice TLS protocols #251

Closed jburel closed 4 years ago

jburel commented 4 years ago

The issue was noticed when trying to connect running server on Ubuntu20.04 or CentOS 8 It was possible to connect for example from a mac to Ubuntu20.04 server but not possible to connect to Ubuntu20.04 to Ubuntu20.04 server. See https://travis-ci.org/github/ome/omero-install/jobs/725545346 This PR adds support for multiple protocols

see https://github.com/ome/omero-py/issues/250

mtbc commented 4 years ago

:+1: With this (and maybe omero-certificates) we also shouldn't have to fiddle with /etc/ssl/openssl.cnf for the Debian 10 installation.

manics commented 4 years ago

I think you'll still need omero-certificates on the server side, but hopefully no other server or client config will be required

manics commented 4 years ago

I've edited the title so it can go straight into a changelog

jburel commented 4 years ago

@mtbc I did not notice problem with debian 10 docker image

mtbc commented 4 years ago

https://docs.openmicroscopy.org/omero/5.6.2/sysadmins/unix/server-debian10-ice36.html has a "Fix openssl issues" section.

jburel commented 4 years ago

I forgot about that! This is done in the docker image that's true

manics commented 4 years ago

So.... we need another docs release?

jburel commented 4 years ago

We will need a doc release regardless cf. https://github.com/ome/omero-install/pull/244

mtbc commented 4 years ago

To get the latest commit I did,

pip install -U https://codeload.github.com/jburel/omero-py/zip/ice_protocols

Together with omero-certificates this lets me log in from CLI but not to import,

2020-09-11 09:55:08,093 1144       [      main] INFO       ome.formats.OMEROMetadataStoreClient - Attempting initial SSL connection to 127.0.0.1:4064
2020-09-11 09:55:08,413 1464       [      main] ERROR  formats.importer.cli.CommandLineImporter - Error during import process.
Ice.SecurityException: javax.net.ssl.SSLHandshakeException: Received fatal alert: protocol_version

My system is a weird mix of stuff so I wouldn't read too much into that, my point is more that: whatever testing we do for this kind of thing should probably include an import.

jburel commented 4 years ago

Using today's omero-py build https://travis-ci.org/github/ome/omero-install/builds/726206712

I will add an import to the testing process via travis

manics commented 4 years ago

No objections so merging

imagesc-bot commented 3 years ago

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/omero-import-error-ice-securityexception-javax-net-ssl-sslhandshakeexception-no-appropriate-protocol-again/52154/17