search

ome / omero-py

Python project containing Ice remoting code for OMERO
https://www.openmicroscopy.org/omero
GNU General Public License v2.0
20 stars 33 forks source link

Add GitHub workflow #261

Closed manics closed 3 years ago

manics commented 3 years ago

I got fed up of waiting for Travis. If we decide to go this route we'll need to setup (and test) the Pypi deploy secrets, and should delete .travis.yml

sbesson commented 3 years ago

I am getting increasingly convinced of our upcoming transition to GitHub workflows so no objection from my side. A few questions:

joshmoore commented 3 years ago
  • Does something need to be activated?

I'm not convinced adding a workflow in a PR always works as expected (or at all?)

  • should we try a PyPI release via GitHub action for omero-py 5.8.2?

WFM.

manics commented 3 years ago

I'm not convinced adding a workflow in a PR always works as expected (or at all?)

It usually works for me, but maybe it depends on the repo settings?

sbesson commented 3 years ago

I am tempted in that case to trust https://github.com/manics/omero-py/actions/runs/282486285 and merge. Although we probably need to remove at least the Travis deployment step to avoid having 2 places releasing concurrently. Separate PR?

manics commented 3 years ago

I've removed the deploy step so we can merge it and test the workflow runs as expected. I'll then add the deploy step back and remove travis in the next PR

sbesson commented 3 years ago

:+1: a general question I have is about what the name of GitHub workflow should be esp. if there is a single one. Options I can think of workflow.yml, main.yml, build.yml. This does not need ot block this PR for the reasons described above.

sbesson commented 3 years ago

See https://github.com/ome/omero-py/actions/runs/282610505