ome / omero-py

Python project containing Ice remoting code for OMERO
https://www.openmicroscopy.org/omero
GNU General Public License v2.0
20 stars 33 forks source link

download provider uses NamedTemporaryFile #274

Closed will-moore closed 3 years ago

will-moore commented 3 years ago

See https://github.com/ome/omero-scripts/pull/180

The Populate_Metadata script that uses DownloadingOriginalFileProvider needs to read the temp file with a specific encoder. By returning a NamedTemporaryFile, consumers can open the temp file themselves.

dominikl commented 3 years ago

👍 Makes sense, good to merge. I would never have expected that tempfile.TemporaryFile() can create a file without a "visible" file name, Python's always good for a surprise.