ome / omero-py

Python project containing Ice remoting code for OMERO
https://www.openmicroscopy.org/omero
GNU General Public License v2.0
20 stars 33 forks source link

Improve "omero login" prompt #300

Open pwalczysko opened 3 years ago

pwalczysko commented 3 years ago
omero login
Previously logged in to outreach.openmicroscopy.org:4064 as trainer-1
Server: [outreach.openmicroscopy.org:4064]

See https://forum.image.sc/t/download-full-projects-with-their-datasets/56434/9 and also some experience during outreach is suggesting that the prompt as above is not perceived by a naive user as one which they can overwrite.

Suggestion :

cc @joshmoore

joshmoore commented 3 years ago

Transferred issue since the related change would need to be inserted at approximately https://github.com/ome/omero-py/blob/master/src/omero/plugins/sessions.py#L475, but likely conditionally since with all values were passed, nothing needs setting.

joshmoore commented 3 years ago

You can see https://github.com/willmcgugan/rich#readme for features that you can potentially request (see https://github.com/ome/omero-py/issues/217)

dominikl commented 3 years ago

Imo listing the default in [ ] and accepting it with a simple return or changing it by typing something else, is pretty standard CLI behaviour.