search

ome / omero-py

Python project containing Ice remoting code for OMERO
https://www.openmicroscopy.org/omero
GNU General Public License v2.0
20 stars 33 forks source link

Implementation for DatasetColumn #309

Closed muhanadz closed 2 years ago

muhanadz commented 2 years ago

Added implementation for DatasetColumn which was imported from omero.grid in omero metadata but was never implemented. DatasetColumn header defined here.

This PR hopes to start the process of supporting dataset IDs as column type (currently only dataset names are supported). omero metadata ready to handle DatasetColumn here

Might need to add DatasetColumn test case here once merged.

joshmoore commented 2 years ago

Thanks, @muhanadz. :+1: for getting a test in ome/openmicroscopy, both at that location but perhaps more generally with the use-case that you're covering. The test can still go green even before this PR is merged since all PRs are merged together daily for testing purposes:

joshmoore commented 2 years ago

Thanks for slogging it through, @muhanadz! https://github.com/ome/openmicroscopy/pull/6300 is green and in. :heart: