search

ome / omero-py

Python project containing Ice remoting code for OMERO
https://www.openmicroscopy.org/omero
GNU General Public License v2.0
20 stars 31 forks source link

Also pass omero.db.properties and omero.db.url to reindex #329

Closed chris-allan closed 2 years ago

chris-allan commented 2 years ago

Under certain conditions, in particular those where a specific sslmode ^1 is required, omero.db.properties is an essential property that must be provided for the reindexing code to be able to communicate with the database.

chris-allan commented 2 years ago

@stick will validate this on our side. We have a user who has this requirement in production (sslmode=require) and currently can't reindex because of it.

Couple other thoughts which are possibly beyond the scope of this PR:

  1. If a user is making use of omero.db.url ^1 instead of the individual properties reindexing won't work
  2. If omero.db.pass is not being provided on the command line I'm not sure how reindexing works if a password other than omero is being used (@stick and I will validate this)
chris-allan commented 2 years ago

Also validated that omero.db.pass is provided via the JAVA_OPTS environment variable so we're all good there.

chris-allan commented 2 years ago

Is there a timeline for having this fix released from your side?

None right now. We managed to work around the problem by forcing TLS 1.2 (which is incidentally what the user really wanted anyway).

will-moore commented 1 year ago

FYI: this is now in the recent 5.12.0 release of omero-py