search

ome / omero-py

Python project containing Ice remoting code for OMERO
https://www.openmicroscopy.org/omero
GNU General Public License v2.0
20 stars 31 forks source link

Always report pixeldata time in the output of fs importtime #335

Closed sbesson closed 1 year ago

sbesson commented 1 year ago

While investigating, mismatches between the sum of the import times reported by the CLI command and the import logs, I realised the time for completing this step is being skipped if no rendering settings are assigned. In addition to pyramid generation, several actions are being performed including min/max calculation and pixel/series assignment.

Testing

Without this PR, import a file e.g. a fake image/plate with and without setting the thumbnails

omero import "test&plateRows=4&plateCols=4.fake"
omero import "test&plateRows=4&plateCols=4.fake" --skip thumbnails

Then run omero fs importtime Fileset:<id> on both filesets. Without this PR the pixeldata step of the second command should be omitted from the output. With this PR included, it should be reported in both cases

sbesson commented 1 year ago

@jburel @joshmoore thoughts about scheduling an immediate 5.12.1 release including this bug fix or do you have other changes you would like to see included?

joshmoore commented 1 year ago

None from me.

jburel commented 1 year ago

No other changes from my side after quickly reviewing the open PRs