ome / omero-py

Python project containing Ice remoting code for OMERO
https://www.openmicroscopy.org/omero
GNU General Public License v2.0
21 stars 32 forks source link

add env variable to fix doc generation #348

Closed jburel closed 1 year ago

jburel commented 1 year ago

Workaround discussed so we can generate the API doc. Env variable set in readthedocs

jburel commented 1 year ago

https://omero-py--348.org.readthedocs.build/en/348/omero.util.temp_files.html is now generated

currently https://omero-py.readthedocs.io/en/latest/omero.util.temp_files.html

jburel commented 1 year ago

Barring the one minor comment, this matches what we spoke about regarding the weirdness of the build. I'd still be very interested to know why path() is not behaving as we expect, but also big 👍 for getting the released docs updated.

I will look into it afterwards.

jburel commented 1 year ago

https://omero-py--348.org.readthedocs.build/en/348/omero.util.temp_files.html with 78638a0

jburel commented 1 year ago

@joshmoore any more comments? i will prepare a release so we can have stable and latest

joshmoore commented 1 year ago

:+1: The only thing I got caught up on was whether we should prefix with OMERO_ etc. etc. But perhaps if it's a temporary solution (famous last words...), then it doesn't matter too much.

jburel commented 1 year ago

I will add OMERO to avoid confusion

jburel commented 1 year ago

@joshmoore done

joshmoore commented 1 year ago

Heh. Awesome. Thanks. :+1: GFI.