ome / omero-py

Python project containing Ice remoting code for OMERO
https://www.openmicroscopy.org/omero
GNU General Public License v2.0
20 stars 31 forks source link

cap urllib3 to avoid openssl issue #371

Closed jburel closed 10 months ago

jburel commented 1 year ago

Problem noticed when running the omero-server job on CentOS 7 with SCL Python 3.8 cc @sbesson @khaledk2

sbesson commented 1 year ago

Cross-linking to https://github.com/ome/scc/pull/284 which patched a similar issue (in a build-only dependency) and https://urllib3.readthedocs.io/en/stable/v2-migration-guide.html which explains the issues associated with urllib3 2.x.

This problem will primarily impact CentOS 7 deployments with SCL Python 3.8 and OpenSSL 1.0.x. Unfortunately I am not aware of a classifier that would detect this environment and fallback to urllib3 1.x.

The primary downside of this change is that the capping urrlib3 will happen across the board including in more recent distributions where OpenSSL 1.1.1 or even 3.x are shipped with Python 3.8+. Looking at other changes, it looks like urllib3 2.x also deprecated the urllib3.contrib.pyopenssl module which was used as the basis of https://github.com/ome/omero-py/pull/305.

In summary: