search

ome / omero-py

Python project containing Ice remoting code for OMERO
https://www.openmicroscopy.org/omero
GNU General Public License v2.0
20 stars 31 forks source link

Set minimum version for Pillow (10.0.0) and Python (3.8) #388

Closed jburel closed 5 months ago

jburel commented 6 months ago

Problem noticed while working on https://github.com/ome/omero-scripts/pull/214

jburel commented 5 months ago

since Pillow 10 has been around for over 6 months (01/07/2023). I think we should have to 10.0.0 as a minimum

sbesson commented 5 months ago

Thanks @jburel . Requiring Pillow>10 effectively enforces Python 3.8 as the minimal supported version in upcoming OMERO.py versions - see https://pillow.readthedocs.io/en/latest/installation.html#python-support

Given the current timeline for Python 3.x support and the fact Python 3.7 and earlier is EOL, no objections with enforcing this from my side

jburel commented 5 months ago

@will-moore any comment from your side? It will be good to have that PR merged and do a release so we can move forward with the test-infra upgrade work

jburel commented 5 months ago

@will-moore do you suggest to do box = font.getbbox(...) then box[2]-box[0] for the width to be on the safe side.? This is no the case in the changes you made for figure. I will also need to adjust the change in omero-scripts

jburel commented 5 months ago

@will-moore I have made the changes to calculate the diff. I have also fixed the code in https://github.com/ome/omero-scripts/pull/214

will-moore commented 5 months ago

That looks great. Wasn't sure it was worth it given that we don't know it's needed, but nice to be sure - thx

jburel commented 5 months ago

Since the requirement has been modified i.e. minimum version for Pillow. Proposing to merge and tag as 5.18.0

sbesson commented 5 months ago

Should https://github.com/ome/omero-py/blob/0958d2ba30f92990d6dea077fa359356577c6275/setup.py#L221 also be modified to capture the minimal Python requirement?