ome / omero-py

Python project containing Ice remoting code for OMERO
https://www.openmicroscopy.org/omero
GNU General Public License v2.0
21 stars 33 forks source link

Forward HTTP(S) PROXY env vars to subprocesses #395

Open TorecLuik opened 7 months ago

TorecLuik commented 7 months ago

Hey OME,

I found that the HTTP(S) PROXY env vars do not get forwarded to the subprocess on the processor (running the scripts). So my script could not access the web as I would have expected, behind the proxy server (because it is making its own environment variables).

Could you forward the 3 env vars to the subprocesses by default?

            "HTTP_PROXY",
            "HTTPS_PROXY",
            "FTP_PROXY"

https://github.com/ome/omero-py/blob/master/src/omero/processor.py#L150

Perhaps also "no_proxy" then, though I don't need that.

Or is there a way to configure this already through some omero_config ?

Regards, Torec

joshmoore commented 7 months ago

Hi @TorecLuik. No, that's the right location for updating it. Looking at https://superuser.com/a/1690537 it might could use a little thought if it can't be made extensible ....

TorecLuik commented 7 months ago

Hey @joshmoore Haha, great history of the vars. Well, all bases would be covered by forwarding uppercase & lowercase of all 4 then, right? Supporting all tools and environments.