search

ome / omero-py

Python project containing Ice remoting code for OMERO
https://www.openmicroscopy.org/omero
GNU General Public License v2.0
22 stars 32 forks source link

plugins: obj #86

Closed jburel closed 5 years ago

jburel commented 5 years ago

Message no longer exists Print the error instead

joshmoore commented 5 years ago

Is there a change in the output for the user? One option would be to access the message via args: https://portingguide.readthedocs.io/en/latest/exceptions.html#iterating-exceptions

joshmoore commented 5 years ago

https://github.com/ome/openmicroscopy/pull/6144/files#diff-963231c1845e662ac0e67d218bcf118eR102 suggests that there is no change in the output?

jburel commented 5 years ago

I did not notice any changes. I could use args as suggested in the guide if we prefer

jburel commented 5 years ago

Read message from args as suggested in the porting guide

jburel commented 5 years ago

The 2 tests listed in the description should still be green in both py2 and 3

joshmoore commented 5 years ago

Both tests pass in merge (224) and py3 (40)