search

ome / omero-py

Python project containing Ice remoting code for OMERO
https://www.openmicroscopy.org/omero
GNU General Public License v2.0
22 stars 32 forks source link

populate-roi #95

Closed jburel closed 5 years ago

jburel commented 5 years ago

fix reading of original file This does fix the test https://py3-ci.openmicroscopy.org/jenkins/job/OMERO-test-integration/30/testReport/junit/OmeroPy.test.integration.metadata.test_populate/TestPopulateRois/testPopulateRoisPlate/ but it now shows the same error as the other tests i.e.

 ValueError: findObjectFactory expects a string for argument 'id'
E       
E           message = BAD COLUMN TYPE: b'::omero::grid::ImageColumn' for Image
joshmoore commented 5 years ago

merge 217 failed with:

E       TypeError: TemporaryFile() got an unexpected keyword argument 'encoding'
jburel commented 5 years ago

I saw that but strangely enough I did not have the error when I ran it locally

joshmoore commented 5 years ago

Merge (224) and py3 (40) has yet another failure message. Merging and I'll try to get this green today.

joshmoore commented 5 years ago

btw, @jburel, looking at:

Character   Meaning
'r'     open for reading (default)
'w'     open for writing, truncating the file first
'x'     open for exclusive creation, failing if the file already exists
'a'     open for writing, appending to the end of the file if it exists
'b'     binary mode
't'     text mode (default)
'+'     open a disk file for updating (reading and writing)
'U'     universal newlines mode (deprecated)

https://docs.python.org/3/library/functions.html#open, did you also try using a binary mode?

jburel commented 5 years ago

I tried in binary mode but it broke other things down the line. So the impact of the changes was much greater