search

ome / omero-rois

OMERO python ROI utils
https://omero-rois.readthedocs.io/
GNU General Public License v2.0
2 stars 4 forks source link

pre-commit (black, flake8) #8

Closed manics closed 3 years ago

manics commented 4 years ago

Add black autoformatter using pre-commit.

This is the same as https://github.com/ome/omero-web/pull/218

sbesson commented 4 years ago

From https://github.com/ome/omero-rois/pull/8/checks?check_run_id=1385113188, the omero-test-infra based flake8 failed with

./setup.py:30:80: E501 line too long (88 > 79 characters)
./setup.py:113:80: E501 line too long (88 > 79 characters)
./docs/conf.py:151:80: E501 line too long (80 > 79 characters)
./test/integration/test_saved_masks.py:91:80: E501 line too long (84 > 79 characters)
./test/integration/test_saved_masks.py:112:80: E501 line too long (85 > 79 characters)
./test/integration/test_saved_masks.py:128:80: E501 line too long (87 > 79 characters)
./test/integration/test_saved_masks.py:147:80: E501 line too long (84 > 79 characters)

This probably suggests we will need to think seriously about how to handle flake8/black for all Python-based OMERO plugins.

joshmoore commented 3 years ago

Green again after reverting to master. 👍