search

ome / omero-scripts

Core OMERO Scripts
https://pypi.org/project/omero-scripts/
12 stars 32 forks source link

T and Z fix for Images_from_ROIs.py #123

Closed emilroz closed 7 years ago

emilroz commented 7 years ago

T, Z and C are optional. The script execution fails if T or Z is unset.

Testing: create shape without explicitly setting T and Z and it should run smoothly until completion.

jburel commented 7 years ago

Adjusted the integration test introduced as part of https://github.com/openmicroscopy/openmicroscopy/pull/4914 to cover the case when z and t are not set.

jburel commented 7 years ago

https://ci.openmicroscopy.org/view/Failing/job/OMERO-DEV-merge-integration-python/lastCompletedBuild/testReport/OmeroPy.test.integration.scriptstest.test_util_scripts/ passes

jburel commented 7 years ago

Changes make sense, and test (in another PR) is green. Merging thanks for spotting that one

joshmoore commented 7 years ago

unwrap(shape.getTheT()) ?