Closed will-moore closed 6 years ago
Tested on same image on latest and merge This is certainly an improvement Ready to merge
Quick question: what was the largest size image that this was tested with? At what size would we expect this to have issues?
Both before and after this PR, the script fails with Big images (internal exception Non-tile based writing unsupported.
) and works OK with images just under 3k x 3k. Tested with 2789 x 2865
.
Thanks for checking that, @will-moore. Down the road I could see one or more of these as defensive programming items in the scripts:
But considering this didn't work before or after at > 3k x 3k, merging.
https://trello.com/c/xxnprbWz/35-combineimages-use-setplane
Simply use
rawPixelStore.setPlane()
instead ofsetRow()
to improve speed of CombineImages.py script.To test: