Combine Images setPlane

ome / omero-scripts

Core OMERO Scripts

https://pypi.org/project/omero-scripts/

12 stars 32 forks source link

Combine Images setPlane #143

Closed will-moore closed 6 years ago

will-moore commented 6 years ago

https://trello.com/c/xxnprbWz/35-combineimages-use-setplane

Simply use rawPixelStore.setPlane() instead of setRow() to improve speed of CombineImages.py script.

To test:

check that script still working as normal.
Travis should also be green (integration test passing)

jburel commented 6 years ago

Tested on same image on latest and merge This is certainly an improvement Ready to merge

joshmoore commented 6 years ago

Quick question: what was the largest size image that this was tested with? At what size would we expect this to have issues?

will-moore commented 6 years ago

Both before and after this PR, the script fails with Big images (internal exception Non-tile based writing unsupported.) and works OK with images just under 3k x 3k. Tested with 2789 x 2865.

joshmoore commented 6 years ago

Thanks for checking that, @will-moore. Down the road I could see one or more of these as defensive programming items in the scripts:

Doc string saying, "not big image safe"
Separate subdirectory for big/non-big image-compatible scripts
A script_utils or gateway method which asserts "not is_big_image"
A keyword on scripts for whether or not they work with big images

But considering this didn't work before or after at > 3k x 3k, merging.