ome / omero-scripts

Core OMERO Scripts
https://pypi.org/project/omero-scripts/
12 stars 32 forks source link

Add 'Images_Per_Well' support to Dataset_To_Plate #146

Closed will-moore closed 5 years ago

will-moore commented 5 years ago

See recent queries about adding multiple Images per Well: https://www.openmicroscopy.org/community/viewtopic.php?f=4&t=8711&p=20693, and https://www.openmicroscopy.org/community/viewtopic.php?f=6&t=8706

This PR updates the Dataset_To_Plate script to support multiple Images per Well.

To test:

will-moore commented 5 years ago

@sbesson We have a test for this script at https://github.com/ome/scripts/blob/6e9ca9bc26182a8f39448e413c74ecf93c268850/test/integration/test_util_scripts.py#L130 but it would need a fair bit more work to support the matrix of various input values for all the script parameters. Maybe I'll just add the new Images_Per_Well parameter.

sbesson commented 5 years ago

Thanks @will-moore. Agreed that covering the whole set of input values is outside the scope of this change and :+1: for focusing on the newly added parameter.

will-moore commented 5 years ago

Added test to test the Images_Per_Well parameter (and a couple of others)

jburel commented 5 years ago
./test/integration/test_util_scripts.py:145:9: F841 local variable 'n' is assigned to but never used
./test/integration/test_util_scripts.py:196:5: E303 too many blank lines (2)
joshmoore commented 5 years ago

Ah of course, thanks. That’s what I get for reviewing with whitespace off