Movie ROI figure errors on py3

[pwalczysko]

See line 21 of https://docs.google.com/spreadsheets/d/1ry6vS0dmsylFQDAiIZDrPC3kXNpnHSMtK-2yj5X8jaU/edit#gid=420881033

"Move ROI Figure script ends with

          Traceback (most recent call last):

  File ""/home/omero/workspace/OMERO-web/omero-virtualenv/lib/python3.6/site-packages/django/core/handlers/exception.py"", line 41, in inner
    response = get_response(request)

  File ""/home/omero/workspace/OMERO-web/omero-virtualenv/lib/python3.6/site-packages/django/core/handlers/base.py"", line 187, in _get_response
    response = self.process_exception_by_middleware(e, request)

  File ""/home/omero/workspace/OMERO-web/omero-virtualenv/lib/python3.6/site-packages/django/core/handlers/base.py"", line 185, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)

  File ""/home/omero/workspace/OMERO-web/OMERO.web/lib/python/omeroweb/decorators.py"", line 485, in wrapped
    retval = f(request, *args, **kwargs)

  File ""/home/omero/workspace/OMERO-web/OMERO.web/lib/python/omeroweb/decorators.py"", line 535, in wrapper
    context = f(request, *args, **kwargs)

  File ""/home/omero/workspace/OMERO-web/OMERO.web/lib/python/omeroweb/webclient/views.py"", line 3698, in script_ui
    raise ex

  File ""/home/omero/workspace/OMERO-web/OMERO.web/lib/python/omeroweb/webclient/views.py"", line 3693, in script_ui
    params = scriptService.getParams(long(scriptId))

  File ""/home/omero/workspace/OMERO-web/OMERO.web/lib/python/omero/gateway/__init__.py"", line 4748, in __call__
    return self.handle_exception(e, *args, **kwargs)

  File ""/home/omero/workspace/OMERO-web/OMERO.web/lib/python/omeroweb/webclient/webclient_gateway.py"", line 2131, in handle_exception
    e, *args, **kwargs)

  File ""/home/omero/workspace/OMERO-web/OMERO.web/lib/python/omero/gateway/__init__.py"", line 4745, in __call__
    return self.f(*args, **kwargs)

  File ""/home/omero/workspace/OMERO-web/OMERO.web/lib/python/omero_api_IScript_ice.py"", line 842, in getParams
    return _M_omero.api.IScript._op_getParams.invoke(self, ((scriptID, ), _ctx))

omero.ValidationException: exception ::omero::ValidationException
{
    serverStackTrace = 
    serverExceptionClass = 
    message = Can't find params for 3855!
No stdout.
stderr is in file 5078:
---------------------------------
Traceback (most recent call last):
  File ""./script"", line 836, in <module>
    run_script()
  File ""./script"", line 728, in run_script
    ckeys.sort()
AttributeError: 'dict_keys' object has no attribute 'sort'

---------------------------------

}

<WSGIRequest: GET '/web/webclient/script_ui/3855/?Image=985'>
        "

[pwalczysko]

sorry, gave it a wrong title originally, @will-moore @joshmoore @sbesson @manics

[sbesson]

Migrated to ome/scripts as this is the source of the error. I would have expected https://github.com/ome/scripts/pull/159/files#diff-06a21edd4e57f7b8e73a4e2d3defc5f3L727 to prevent such an error to show up. It might be worth double checking the deployment included this PR which fixes the core OMERO scripts.

[pwalczysko]

@sbesson funnily enough, the "Movie ROI figure" imho is not a "webclient_figure" script.

The three scripts mentoned in the PR https://github.com/ome/scripts/pull/159 indeed do not work either though.

[pwalczysko]

note though: As to be gleaned from the lines 16 and 17 of https://docs.google.com/spreadsheets/d/1ry6vS0dmsylFQDAiIZDrPC3kXNpnHSMtK-2yj5X8jaU/edit#gid=420881033, the three scripts mentioned by @sbesson fail with differing errors - possibly the PR https://github.com/ome/scripts/pull/159 fixed just one layer of problems ? Definitely a though investigation is needed - @will-moore - the erroring of scripts as experienced in the testing is manifold, hard to believe this will be fixed by one single fix.

[will-moore]

Fixed in https://github.com/ome/omero-scripts/commit/73cd9b1461bc11be5bc4d94dae48a635524f7a3e