search

ome / omero-scripts

Core OMERO Scripts
https://pypi.org/project/omero-scripts/
12 stars 32 forks source link

Fix omero-scripts packaging #163

Closed sbesson closed 4 years ago

sbesson commented 4 years ago

This defines each script directory as package and declares them in packages for inclusion in the source distribution

See https://github.com/ome/openmicroscopy/pull/6181#issuecomment-557520702. This should be the first step towards being able to upload omero-scripts source distributions to PyPI for consumption for the OMERO distribution bundles.

joshmoore commented 4 years ago

Makes sense. We'll just need to be careful when adding new directories.

sbesson commented 4 years ago

See the tar.gz of https://py3-ci.openmicroscopy.org/jenkins/job/OMERO-python-superbuild-build/ which now includes all scripts.

Proposing to open a PR against ome/openmicroscopy to consume this source distribution artifact rather than the GitHub archive and have it tested by daily CI builds. If tests keep passing, proposed next steps would be: 1- rename this repository as omero-scripts, 2- bump the version to 5.6.dev1, 3- add the infrastructure to release to PyPI, 4- create a pre-release, 5- update etc/omero.properties to unpack this artifact like the other Python components

joshmoore commented 4 years ago

In general, all sounds fine. The only thing that should be verified is that pip install omero-scripts doesn't lead to any weirdness. If it does, then we should make that clear on PyPI.