search

ome / omero-scripts

Core OMERO Scripts
https://pypi.org/project/omero-scripts/
12 stars 32 forks source link

batch ROI export CSV unicode #165

Closed will-moore closed 4 years ago

will-moore commented 4 years ago

Fixes #158. This reverts commit d9119def3237feefe45b7972e024eb159102d98d. Shouldn't be needed once we have sys.stdout.encoding UTF-8 on the server.

Requires https://github.com/ome/omero-py/pull/150

To test, export ROIs from an image with pixel size of microns and check that µm is written to CSV columns correctly.

jburel commented 4 years ago

script not available

will-moore commented 4 years ago

Don't know why scripts are not uploaded to the server. But I just uploaded this script manually (from this branch).

jburel commented 4 years ago

area (µm) This should be area (µm²) iviewer works correctly

also the values could be rounded e.g. 66.95859863900198 => 66.959

will-moore commented 4 years ago

This PR is just rolling back the .encode() that we don't need now. Not intending to add new features. Also, I don't know how easy it is to write superscript to a text file. I'm not sure we should be rounding here as the output is not for display but for further analysis (equivalent to exporting a lossy jpeg instead of tiff for analysis).

jburel commented 4 years ago

My point is that iviewer and the script generate both a CSV but one round the result one does not that could be very confusing for user I will create an issue for unit display

jburel commented 4 years ago

issues #168 and #169 created Merging the PR