Closed will-moore closed 2 years ago
This pull request has been mentioned on Image.sc Forum. There might be relevant details there:
What is the next step if a movie is a desired end-product ? Combine images script ?
Bug Taking the FRAP image in https://workshop.openmicroscopy.org/webclient/?show=image-28669 and not checking the Make Image stack checkbox, I still get the image stack.
Edit: Follow-up on the above: When I do check the Make Image stack checkbox, I do not get image stack, just one single plane.
Marking as a bug, it seems other way around than it should be, or rather, more precisely, in the case where I do not check the checkbox, I would expect many single images, which does not happen either.
As discussed with @will-moore , maybe just adjust the description of the script.
the script principally does what we want, it is historically much more elaborate in comparison of with what is needed in a present case.
Understood now what the script is doing. It is definitely catering for the new case and the behaviour is improved.
Ready to merge fmpov.
Steps to update this on nightshade server:
To test the last commit - drag the Rectangle outside the bounds of the image. Script should run without an error.
To test the last commit - drag the Rectangle outside the bounds of the image. Script should run without an error.
Works as described, it does not crash when ROIs are outside of the image in some timepoints. (could also repeat the crash with the previous script)
All seems good to me here.
From user request to create a Movie from an ROI when the ROI moves in x and y over time.
This PR improves the
Images_from_ROIs.py
script so that the X and Y of the rectangle at each time point are used to crop the image.To test:
Images_From_ROIs
script (your hierarchy might look a bit different)You can run this script with the default values.
A new Image should be created for (each) ROI and the crop at each time-point should respect the position of the Rectangle at that time-point. These will be in a new Dataset (called
from_ROIs
by default).NB: to export each of these Images as a Movie, use the
Make Movie
functionality for each one in turn.cc @pwalczysko