search

ome / omero-scripts

Core OMERO Scripts
https://pypi.org/project/omero-scripts/
12 stars 32 forks source link

Fix 'No permissions' error in Make_Movie.py. See #12227 #76

Closed will-moore closed 10 years ago

will-moore commented 10 years ago

This fixes https://trac.openmicroscopy.org.uk/ome/ticket/12227

To test, try running Make_Movie script (this will have to be locally since mencoder isn't installed on trout https://trello.com/c/0thKrlX5/449-mencoder-on-trout). The movie should be uploaded to OMERO as a file annotation and returned.

ximenesuk commented 10 years ago

Should Make_Movie be available from the clients?

ximenesuk commented 10 years ago

@joshmoore have there been any recent changes that might have caused this problem on just 5.1?

Also, given the continuing intermittent fails, such as http://ci.openmicroscopy.org/view/Failing/job/OMERO-5.1-merge-integration-python/lastCompletedBuild/testReport/test.integration.test_permissions/TestPermissions/testUseOfRawFileBeanScriptReadCorrectGroup/ on both 5.0 and 5.1 with this reason, is this definitely a consistent problem?

will-moore commented 10 years ago

@ximenesuk Make_Movie is available in Insight (from the figure generation icon - top right toolbar of right panel) but not in Web, since I haven't built the custom UI for this that Insight has.

ximenesuk commented 10 years ago

@will-moore thanks, I always forget there are scripts over there!

I can reproduce the problem Will is seeing and confirm that this commit fixes that problem. It'd still be good to know the whys and wherefores before merging this though.

joshmoore commented 10 years ago

Without the Java portion of the stacktrace, I'm unsure if this is related to https://github.com/openmicroscopy/openmicroscopy/pull/2450 or not. I wouldn't expect there to be a difference in this regard between dev_5_0 and develop, but since we still don't know what's setting -1 for root in openmicroscopy/openmicroscopy#2450, either, there could be a knock-on effect. If it's safe to not have this, then I would think it's a good idea to get rid of it. Happy to discuss.

joshmoore commented 10 years ago

Assuming you guys don't have any other leads either and we should just merge?

ximenesuk commented 10 years ago

Fine by me.

joshmoore commented 10 years ago

Since the cause was unclear, I'm marking this no-rebase for the moment. If the problem arises on 5.0, we can rebase.

--no-rebase