search

ome / omero-signup

OMERO.web app to allow anyone to signup for an OMERO account
https://pypi.org/project/omero-signup/
GNU Affero General Public License v3.0
1 stars 7 forks source link

Increase delay between email attempts #16

Closed sbesson closed 3 years ago

sbesson commented 3 years ago

Fixes #8

This commits attempts to mitigate LockTimeout exceptions thrown during an email request.

The default behavior is to try the SendEmailCmd 10 times with a 500ms delay. This PR makes the delay between attempts configurable and increases the default value to 5000ms.

joshmoore commented 3 years ago

No immediate objections, but is this very different from changing the time between the calls to the loop to be more than 500ms?

sbesson commented 3 years ago

I debated increasing the interval between loops vs adding another retry logic. I have no strong opinion but I would agre increasing the loop interval might be a less invasive change we could deploy shortly to at least see if it reduces the occurrences of LockTimeout.

sbesson commented 3 years ago

Deployed and tested on pub-omero

sbesson commented 3 years ago

Tagged as 0.3.0 and manually deployed on demo.openmicroscopy.org. Let's see if that reduces the number of LockTimeout seen during the automatic sign-up.