search

ome / omero-test-infra

Test infrastructure for decoupled repositories
BSD 2-Clause "Simplified" License
3 stars 13 forks source link

Design questions #1

Open joshmoore opened 6 years ago

joshmoore commented 6 years ago

TODO:

sbesson commented 6 years ago

Re omero-test-daemon-c7-docker, it would make sense to re-use it from a historical perspective, considering the former as version 0.0.1. of what this is trying to achieve. I don't know if we'll end up doing git rm && git add though Should https://hub.docker.com/r/openmicroscopy/omero-test-daemon-c7/ be deprecated/dropped? If we are not reusing the repository, we should probably deprecate, archive and redirect it to the new testing infrastructure.

I would vote for keeping the omero-* convention when possible. omero-test-infra would work for me.

What are the pros and cons of running omeroci/test-data either on the client docker or server docker? Are there cases where we would like to configure in which location this should be run? In which case, we could probably make that configurable using the filename or more advanced strategies.

jburel commented 6 years ago

I will make sense to re-use if https://github.com/openmicroscopy/omero-test-daemon-c7-docker if possible

for the name I agree with @sbesson we should keep omero- as a prefix.omero-test-infra is a good as any and I don't have a better suggestion

joshmoore commented 6 years ago

I've renamed this repo to omero-test-infra and the following 4 PRs are green:

I was hoping to extract the PyTest command and make use of https://github.com/openmicroscopy/openmicroscopy/pull/5585 but it's too difficult to consume the devspace OMERO.server build. (Here we need a decoupled python-omero or python-omero-testlib)

My proposal would be to merge all 4 of those, perform a release where appropriate, and then consider this version 0.1.0 of the new test infra. I'd don't see a straight-forward way to reuse omero-test-daemon but if it's worth it, I'll invest more time.

joshmoore commented 6 years ago

Few decisions that have been made over scattered conversations (open for veto):

joshmoore commented 6 years ago

Discussion with @jburel and @sbesson today:

jburel commented 6 years ago

app-build already exists. it is currently used to run the tests This might need to be renamed

jburel commented 6 years ago

I had to make various modifications to use test-infra for figure and iviewer (more adjustments due to iviewer repo layout) I will hopefully have a PR tomorrow so we can start a discussion

jburel commented 6 years ago

Changes to have iviewer and figure work with test-infra https://github.com/openmicroscopy/omero-test-infra/pull/3

jburel commented 6 years ago

Current implementation assumes that the scripts to test are in a folder omero we will need to relax to handle case like gs/metadata.py I had to make an change to work with figure but we should consider to go a step further

jburel commented 6 years ago

Changes have been made in #3 to handle scripts not directly under /omero Looking at other repositories e.g. https://github.com/openmicroscopy/omero-example-scripts Ignoring the fact that it is not pip installable, there is a "flat" structure. This won't handle by the current implementation or changes in #3

jburel commented 6 years ago

Consider more configuration options for apps e.g. open_with