search

ome / omero-test-infra

Test infrastructure for decoupled repositories
BSD 2-Clause "Simplified" License
3 stars 13 forks source link

Force lowercase in get_project_name #15

Closed joshmoore closed 6 years ago

joshmoore commented 6 years ago

see: https://github.com/ome/rOMERO-gateway/pull/41

Propose as a quick v0.3.2

/cc @sbesson @jburel @dominikl

dominikl commented 6 years ago

That's great, thanks @joshmoore !

sbesson commented 6 years ago

@dominikl have you tested it on https://github.com/ome/rOMERO-gateway/pull/41 (by temporarily cloning this branch rather than the upstream)? Once validated, I think this should be good to merge unless there is a chance this might negatively impact another consumer of omero-test-infra.

joshmoore commented 6 years ago

by temporarily cloning this branch rather than the upstream

Certainly what I did. ;)

unless there is a chance this might negatively impact another consumer

Comments welcome, but I don't think this is the case due to the fact that docker-compose will always lowercase and we should follow that logic.

dominikl commented 6 years ago

Works, good to merge! 👍

joshmoore commented 6 years ago

Tag pushed.