search

ome / omero-test-infra

Test infrastructure for decoupled repositories
BSD 2-Clause "Simplified" License
3 stars 13 forks source link

Python3 support #44

Closed joshmoore closed 4 years ago

joshmoore commented 4 years ago

Modernize omero-test-infra for the OMERO 5.6 (python3-based) line. Consuming repositories may need updates.

Needs:

which in turn need:

Test candidate:

joshmoore commented 4 years ago

Finally green! Pushed a temporary commit to https://github.com/ome/omero-mapr/pull/54/commits/9164f7f4f46fcde5e2d4106a0d9d33fb34d31426 to try it out.

joshmoore commented 4 years ago

On the Python 3 call today, agreed to merge this PR. The impact of that is that travis cron and new PR jobs may start failing if the related repository has not yet been futurized. This is likely a good thing. omero-test-infra will pick up all new docker images that are pushed to docker hub with the 5.6 tag so new PRs should not be needed except for bugs in this repo.

cc: @pwalczysko @dominikl @jburel who missed the call.

sbesson commented 4 years ago

Successfully tested using the futurized render plugin (see https://github.com/ome/omero-cli-render/pull/31). The only suggestion is that OMERODIR might be worth setting in the server container either here or most likely in the upstream Docker image.